avoid clearing timeouts #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, ment to mention @arj |
|
Benchmarks on my machine: closure 3862 |
|
I said "pretty sure I remember setTimout is slow" in flumedb/flumeview-reduce#12 then I saw this PR from a year ago... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a timeout has been recently set, avoid clearing it. clearing timeouts is actually significant!
also added
test/bench.jsclearing half a million timeouts takes 2 seconds.the new approach (which still passes all the tests) checks if an already set timeout was within half the delay time. if so, skips clearing and setting a timeout.
on flumeview-hashtable this is measurable on the benchmark - (note: it only affects append) and other things such as the log implementation and codec have a strong effect, too. but it's still noticable through that.